On Thu, 5 Nov 2026 17:25:18 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> Review comments resolution > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1431: > >> 1429: } >> 1430: movdl(rtmp, shift); >> 1431: andl(rtmp, 31); > > Forgot one minor thing: masking off upper bits is redundant here, the mask is > already applied to the shift operand. And if you drop it, you can also drop > `KILL cr` on `vshiftB_gfni`. > > It could be turned into an assert though (a runtime check halting the JVM on > slow path in fastdebug build). Addressed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4489243402
