On Tue, 17 Nov 2026 06:24:11 GMT, David Holmes <[email protected]> wrote:

> Just to be clear this is only necessary because you are forcing 
> UseBranchProtection on for the GHA tests - right?

Yes, IO.java needs changes because we could be asking for branch protection on 
a machine that doesn't support it and because this patch adds that option in 
our GitHub Actions.

> Those tests don't run in the GHA tier1 testing though do they?

Actually, they do.  IO.java is run as part of the jdk/tier1 part 1 tests (see 
[log](https://github.com/raneashay/openjdk-jdk/actions/runs/44025777656/job/133879065428#step:10:2931)
 for an example) and both DataDumpDcmdTest.java and LoadAgentDcmdTest.java 
tests are run as part of HotSpot tier 1 serviceability tests (see 
[log](https://github.com/raneashay/openjdk-jdk/actions/runs/44025777656/job/133879065436#step:10:879)).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33595#discussion_r4602249927

Reply via email to