On Wed, 18 Nov 2026 03:47:14 GMT, David Holmes <[email protected]> wrote:
>>> Just to be clear this is only necessary because you are forcing >>> UseBranchProtection on for the GHA tests - right? >> >> Yes, IO.java needs changes because we could be asking for branch protection >> on a machine that doesn't support it and because this patch adds that option >> in our GitHub Actions. >> >>> Those tests don't run in the GHA tier1 testing though do they? >> >> Actually, they do. IO.java is run as part of the jdk/tier1 part 1 tests >> (see >> [log](https://github.com/raneashay/openjdk-jdk/actions/runs/44025777656/job/133879065428#step:10:2931) >> for an example) and both DataDumpDcmdTest.java and LoadAgentDcmdTest.java >> tests are run as part of HotSpot tier 1 serviceability tests (see >> [log](https://github.com/raneashay/openjdk-jdk/actions/runs/44025777656/job/133879065436#step:10:879)). > > Okay. I thought the Dcmd tests ran in tier3 and higher. I'm reluctant to > ignore all warnings in these tests. But I'm also reluctant to add tolerance > of this specific warning to those tests as well. I don't see any neat > solution here. Never mind. I now see those tests already ignore all VM warnngs. I misunderstood what the improvement was. Sorry for the noise. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33595#discussion_r4608972900
