On Fri, 20 Nov 2026 10:54:06 GMT, Armin Schrenk <[email protected]> wrote:

>> Add support for native ARM64 Windows MSI pacakges to jpackage.
>> 
>> For some reasoning and more info, check out the ticket on JBS: 
>> https://bugs.openjdk.org/browse/JDK-8361207.
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Armin Schrenk has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains four commits:
> 
>  - add tests
>  - Drop internal enum approach and only switch for Wix4 the architecture.
>  - Merge branch 'master' into JDK-8361207
>    
>    # Conflicts:
>    #  src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java
>  - Add support for arm64 Platform for jpackage/WixPipeline

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java line 
212:

> 210: 
> 211:     // Value of the "-arch" option of the WiX v4+ "build" command for 
> the current platform
> 212:     private static String wix4Arch() {

So the arch of the msi depends on the arch of the system.

Say I run x64 jpackage on arm64 Windows through an emulation layer. It would 
unconditionally produce an arm64 MSI even though it has x64 binaries. Doesn't 
look right.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26093#pullrequestreview-5999446806
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4647748860

Reply via email to