On Fri, 20 Nov 2026 21:02:18 GMT, Alexey Semenyuk <[email protected]> wrote:
> Before the change, it was always x64, regardless of the WiX version. [...]
> This change breaks backward compatibility. Did you consider this implication?
Simply said, no. But the behavioral change is an integral part of this PR. It
follows from the question "Given a ARM64 Windows, what architecture MSI should
the JDK produce?"
Currently an ARM64 JDK produces an MSI marked for x64 platforms, but the basic
payload is NOT x64 (i.e. app launcher `jpackageapplauncher.exe`). _This is
clearly a bug_, because the jpackage does not fail and simply produces a broken
installer. From my point of view, this is not a desired behavior the JDK should
keep.
With my changes, we reduce the bug surface by fixing it for WiX 4 and above.
┌───────────────────────────────┬─────────┬─────────────────────────────────────────────┐
│ jpackage's JDK │ WiX │ MSI platform
│
├───────────────────────────────┼─────────┼─────────────────────────────────────────────┤
│ x64 (on x64 or ARM64 Windows) │ 3 or 4+ │ x64
│
├───────────────────────────────┼─────────┼─────────────────────────────────────────────┤
│ ARM64 │ 4+ │ Arm64 (new)
│
├───────────────────────────────┼─────────┼─────────────────────────────────────────────┤
│ ARM64 │ 3 │ x64, with ARM64 payloads (as
before) │
└───────────────────────────────┴─────────┴─────────────────────────────────────────────┘
It can be also fixed for WiX3, version 3.14+ (released Feb. 2024). Reducing
even further the bug window.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4652065852