I just did a quick test and the "#NNNN" linking in commit messages only seems to occur if the issue exists at the time of pushing a commit. See https://github.com/brettcannon/gidgethub/commit/31fd4df5e3ade210fbfa39e557095c1516c02c27 for an instance where "#2" didn't link since I didn't have an issue #2 yet, https://github.com/brettcannon/gidgethub/commit/92434150efb27c75a738c3ba37311ea2590952e7 which did link because #2 existed, and https://github.com/brettcannon/gidgethub/commit/d2640d7fa7671049361d24a2c85203c50ce98882 which didn't link in the title even though I created an issue after I pushed that commit.
And since we will be creating a new project there will be no pre-existing issues to accidentally link to when we push the converted repo. On Fri, 3 Feb 2017 at 16:35 Ned Deily <[email protected]> wrote: > On Feb 3, 2017, at 19:02, Senthil Kumaran <[email protected]> wrote: > > On Wed, Feb 1, 2017 at 4:51 PM, Brett Cannon <[email protected]> wrote: > >> That's a question for Senthil, but I would be a little worried about > editing > >> the history as the match should be probably s/issue #(\d+)/bpo-\1/ and > it > >> shows how easy it is to miss edge cases. > > It's easy to make the changes in the commit messages. It could be done > > at the conversion level by patching hg-git[1] that we plan to use. > > We will have to come a decision on if it is desirable to do it and the > > format that is preferable. > > It seems to be that this is a pretty big usability issue and that this is > the one chance we might have to "painlessly" deal with it if we can, > assuming github.com doesn't provide some configuration options for this > in the future. So my vote would be to at least try to do a test of this > and see what results pop up. OTOH, I don't want the migration to bog down > for weeks in seeking a perfect solution. > > It would be great if you could try something, Senthil. Other opinions? > > -- > Ned Deily > [email protected] -- [] > > _______________________________________________ > core-workflow mailing list > [email protected] > https://mail.python.org/mailman/listinfo/core-workflow > This list is governed by the PSF Code of Conduct: > https://www.python.org/psf/codeofconduct >
_______________________________________________ core-workflow mailing list [email protected] https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
