> On Feb 22, 2017, at 11:17 PM, Nick Coghlan <ncogh...@gmail.com> wrote: > > On 23 February 2017 at 02:25, Barry Warsaw <ba...@python.org> wrote: >> On Feb 22, 2017, at 11:10 AM, Donald Stufft wrote: >> >>> FWIW, I don’t think that creating a new PR and closing the original one is a >>> subpar experience for contributors, particularly if we turn off the bit that >>> requires reviews and just turn on the thing that requires passing >>> tests. Having been in that situation it has never once bothered me to have >>> someone cherry pick my change and amend it. >> >> Since we're squashing commits wouldn't that obliterate the original author's >> credit for the work? > > You can set "--author" when making the new squash commit (we should > document that somewhere, since it's also useful when importing patches > from bugs.python.org). > > Although looking at https://github.com/python/cpython/pull/169 (where > I set the author to Serhiy, since I was importing a patch he wrote), > it seems GitHub doesn't actually *show* the Author information > anywhere that I can find. >
Github automatically sets author of the squash commit based on who opened the PR. — Donald Stufft
_______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
