I only started to use the new workflow today. And I think that the new rules are too restrictive. Enforcing checking and reviews and approvals is a right thing, but what we have now feels like too much.
I feel like a lot of bug fixes will have to be backported. With the current rules I have to open a new PR and ask someones approval *and* wait until Travis completes the build before I can cherry-pick and push. I like GH, git, and all other tools we now have. But current workflow needs to be loosen up a little IMHO. Yury On 2017-02-17 5:39 PM, Barry Warsaw wrote:
I submitted PR#138 on bpo-22807. I got a nice review from a community member and made a small change. All checks have passed. But now I'm stuck and I'm impatient. ;) The change is small enough and I'm happy with it, and I could patiently wait for another core dev to approve it, but in the likely case that no one else is interested in the bug, I'd like to be able to self-approve and accept it. This of course is described as my right in the devguide, along with the responsibility to watch the buildbots and revert the change if there are any problems with it. But it seems like I cannot do that through the GH UI. Right now I'm seeing (X) Review required (✓) All checks have passed (X) Merge is blocked There seems to be no way to self-approve the PR. If I go to 'Files changed' tab and click on 'Review changes', both Approve and Request changes is dimmed. I can only comment on my own PR. I can understand why we might want to prohibit self-approvals, but that's also a regression in the permissions and rights of core developers. I also think it's counterproductive since without that I might have to go begging for a review approval before the branch can land. Is this intentional or an oversight? (As an owner of the project, I took a quick look at the project settings and couldn't find a control for this, but I know other GH projects I contribute to support self-approval.) Cheers, -Barry _______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
_______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
