Erratum 89 is already handled on line 390:

if (!is_cpu_pre_b3()) {

    /* Erratum 89 ... */
    msr = rdmsr(NB_CFG_MSR);
    msr.lo |= 1 << 3;

If this is also needed when CONFIG_K8_REV_F_SUPPORT == 1, then we should
move the existing one out of the
#if CONFIG_K8_REV_F_SUPPORT == 0
so it gets executed in both cases, as opposed to duplicating it.

Alex

On 02/02/2011 07:39 PM, Josef Kellermann wrote:
> This patch fixes a potential system hang.
> Don't know why this patch isn't included if 'CONFIG_K8_REV_F_SUPPORT == 1'.
> 
> Signed-off-by: Josef Kellermann  <mailto://se...@arcor.de><se...@arcor.de> 
> <mailto://se...@arcor.de>
> 


-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to