On Tue, Jan 08, 2008 at 08:25:27AM +0000, Barbie wrote:
> On Tue, Jan 08, 2008 at 01:48:28AM -0500, David Golden wrote:
> > On Jan 7, 2008 7:30 PM, David Golden <[EMAIL PROTECTED]> wrote:
> > > I'll look to add a "skipfile" option to the next CPAN::Reporter to
> > > jump start this, then we can figure out a repository to use.
> > 
> > Uploaded to CPAN a few minutes ago -- two skipfile options ready for
> > live testing.
> > 
> > 1.07_01 Tue Jan  8 01:41:02 EST 2008
> > 
> >     - Added "cc_skipfile" and "send_skipfile" advanced config options to
> >       specify a text file of regex patterns; if a distribution ID
> >       ('AUTHOR/Dist-Name-0.01.tar.gz') matches any pattern in the file, the
> >       author will not be copied on the report (cc_skipfile) or no reports
> >       will be sent at all (skip_sendfile)
> 
> What is the benefit of extra files for no CC and no report at all?
> That's more configuration to get wrong and probably annoy authors if
> they don't want reports but have to update their desires in more than
> one place.

Thinking a little about this, I think that a skipfile and exclude_dists
are two very different things. While they can both use the same format,
their function has a different aim. 

skipfile should contain authors/distribution where authors have
requested no report to be sent to them. The exclude_dists is then a
local setting by the tester that designates whether a distribution is
tested or not.

If an author is listed in the skipfile, their distributions should still
be tested, as cpan-testers is not just for the benefit of authors. It
should just mean that no report is sent to the author, but a report
should still be submitted to cpan-testers.

I think your intention of send_skipfile above is the same as
exclude_dists, but it should be decided by the local tester not the
author. exclude_dists was originally conceived to avoid distributions
being tested which require libraries that weren't install, but grew to
include distros that forever loop or core dumped on my systems.

I'll amend exclude_dists in YACSmoke and look to adding the skipfile
setting.

Cheers,
Barbie.
-- 
Birmingham Perl Mongers - http://birmingham.pm.org
Memoirs Of A Roadie - http://barbie.missbarbell.co.uk

Reply via email to