On Jan 8, 2008 11:08 AM, Barbie <[EMAIL PROTECTED]> wrote:
> > I would suggest adding an
> > "exclude_dists_file" option to let that file be maintained separately
> > if people wish.  Then our approaches will be harmonized.
>
> This I think has merit, although for backwards compatibility I think
> I'll implement both.

I said "add" to suggest supporting both. Sorry if that wasn't clear.

> > DAGOLDEN/CPAN-Reporter-1.0602.tar.gz  -- that makes it easy for
> > one regex to hit either one.
>
> Providing the detection matches correctly, such that a distribution
> exclusion doesn't match an author, e.g. "MAC" for "Net-MAC" should not
> be confused with the PAUSE ID "MAC", then that's fine.
>
> I've currently implemented it as '^' as the first character always
> matches the AUTHOR/DIST pattern, otherwise it matches the distribution
> only. The latter is for backwards compatibility.

I have mixed feeling about this.  On the one hand, it's nice to DWIM.
On the other hand, it's a regex so people should be free to use
whatever they want.  E.g.

# matches AUTHOR
^MAC
# matches dists with MAC
/.*MAC
# matches developer releases (hopefully)
\d_\d
# matches ANDYA's Test::Harness, but not other author's versions
^ANDYA/Test-Harness

If you add too much DWIM to lines with ^, can you still do the latter one?

> It might seem a bit more heavyweight, but YACSmoke can provide the bulk
> testing framework, that CPAN-Reporter doesn't currently have access to.

How much bulk is there?  CPAN.pm has smoke() already to poll and test
the recent list from CPAN.  That's hardly any code and I could copy
most of that.  And much of the accounting of historical tests is
already in CPAN::Reporter.  I wasn't thinking I need much more than
some shim code to grab a list of stuff to test (search.cpan's recent
feed or else the packages list that CPAN downloads) and iterate
through it with:

    CPAN::Shell->test("AUTHOR/Dist-Name-0.01.tar.gz")

CPAN::Reporter does the rest.  I would add a check against
CPAN::Reporter::History to skip if it already has a test result --
making that a public API is a long-standing Todo item for
CPAN::Reporter::History anyway.  How much functionality am I missing?

David

Reply via email to