On Wed, Jun 11, 2014 at 1:37 PM, Jens Rehsack <rehs...@gmail.com> wrote: > I think there're setups where smoke tests run in a private. not routed > network segment. While this is uncommon, probably an envvar is the right > approach, but it should be one like LOCALTESTS_ONLY instead of > NETWORK_IS_AVAILABLE. This allows smokers to disable unwanted network > tests.
If it has to be done via env variable, phrasing this way, negatively like NONINTERACTIVE_TESTING, is better than an env var granting positive permissions. I still think it's better for tests to check rather than rely on testers to set such variables. -- David Golden <x...@xdg.me> Twitter/IRC: @xdg