Description:
Crosswalk for Linux still doesn’t support ‘File Picker’ now.
Since it’s a widely supported feature - especially for desktop - we’re planning 
to implement it.

Affected component:
Crosswalk on Linux

Related feature:
XWALK-950<https://crosswalk-project.org/jira/browse/XWALK-950>

Target release:
Crosswalk 14

Implementation details:
1.Inherit ‘ui::LinuxShellDialog’ to implement the factory class of ‘File 
Picker’ dialog.
   Only ‘ui::LinuxShellDialog::CreateSelectFileDialog’ needs to be overridden.
2. In ‘XWalkBrowserMainParts::PreEarlyInitialization’, feed the instance of the 
factory class to Content.
3. Implement a common child class of ‘ui::SelectFileDialog’ and 
‘aura::WindowObserver’.
  Mostly, it’s referring to the code of ‘select_file_dialog_impl_gtk2.cc’ of 
Chrome.

Misc.:
Actually, we’ve already written a draft patch to test our design.
It only brings two new ‘.cc’ files and has loose couple with ‘Cromium::ui’ - 
only need to implement some interfaces of base class.
And it’s a pretty independent module, can changed to another type of UI (e.g. 
web UI) easily.

Regards,
Peter Wang

_______________________________________________
Crosswalk-dev mailing list
[email protected]
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Reply via email to