Hi Joone, What’s the schedule to land the patch? Will it work for general Linux?
Thanks, Yongkang _____________________________________________ From: Hur, Joone Sent: Tuesday, March 17, 2015 1:18 AM To: Wang, Peter H; crosswalk-dev@lists.crosswalk-project.org Cc: You, Yongkang; Christiansen, Kenneth R; Balestrieri, Francesco; Pozdnyakov, Mikhail; Huo, Halton Subject: RE: Intent to Implement: 'File Picker' of Crosswalk for Linux Hi Peter, I have worked on the file-picker support. https://github.com/crosswalk-project/chromium-crosswalk/pull/218 https://github.com/crosswalk-project/crosswalk/pull/2707 It worked on ozone-wayland, but the patches for Crosswalk doesn’t land because there was a crash problem with the shared-process-mode before. I will test file-picker patches on the dual-process-mode and then land them soon. Thanks, Joone _____________________________________________ From: Wang, Peter H Sent: Sunday, March 15, 2015 11:56 PM To: crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org> Cc: You, Yongkang; Christiansen, Kenneth R; Balestrieri, Francesco; Hur, Joone; Pozdnyakov, Mikhail; Huo, Halton Subject: Intent to Implement: 'File Picker' of Crosswalk for Linux Description: Crosswalk for Linux still doesn’t support ‘File Picker’ now. Since it’s a widely supported feature - especially for desktop - we’re planning to implement it. Affected component: Crosswalk on Linux Related feature: XWALK-950<https://crosswalk-project.org/jira/browse/XWALK-950> Target release: Crosswalk 14 Implementation details: 1．Inherit ‘ui::LinuxShellDialog’ to implement the factory class of ‘File Picker’ dialog. Only ‘ui::LinuxShellDialog::CreateSelectFileDialog’ needs to be overridden. 2. In ‘XWalkBrowserMainParts::PreEarlyInitialization’, feed the instance of the factory class to Content. 3. Implement a common child class of ‘ui::SelectFileDialog’ and ‘aura::WindowObserver’. Mostly, it’s referring to the code of ‘select_file_dialog_impl_gtk2.cc’ of Chrome. Misc.: Actually, we’ve already written a draft patch to test our design. It only brings two new ‘.cc’ files and has loose couple with ‘Cromium::ui’ - only need to implement some interfaces of base class. And it’s a pretty independent module, can changed to another type of UI (e.g. web UI) easily. Regards, Peter Wang
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
