"Wang, Peter H" <[email protected]> writes: > Implementation details: > 1．Inherit ‘ui::LinuxShellDialog’ to implement the factory class of ‘File > Picker’ dialog. > Only ‘ui::LinuxShellDialog::CreateSelectFileDialog’ needs to be overridden. > 2. In ‘XWalkBrowserMainParts::PreEarlyInitialization’, feed the instance of > the factory class to Content. > 3. Implement a common child class of ‘ui::SelectFileDialog’ and > ‘aura::WindowObserver’. > Mostly, it’s referring to the code of ‘select_file_dialog_impl_gtk2.cc’ of > Chrome. > > Misc.: > Actually, we’ve already written a draft patch to test our design. > It only brings two new ‘.cc’ files and has loose couple with ‘Cromium::ui’ - > only need to implement some interfaces of base class. > And it’s a pretty independent module, can changed to another type of UI (e.g. > web UI) easily.
Does this mean we'll start depending on GTK2 on Linux? There are some platforms (for example, Tizen) where it's not even packaged, so adding a strict dependency there would be a bad idea. I remember Joone did some work on a file picker for Ozone-Wayland [1], did you take a look at that one to see if there's anything we can use? [1] https://github.com/01org/ozone-wayland/tree/master/ui/webui _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
