On 11/09/2010 06:10, Christopher Faylor wrote: > On Sat, Sep 11, 2010 at 01:42:49AM +0100, Dave Korn wrote: >> On 10/09/2010 22:43, Christopher Faylor wrote: >> >>> Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted >>> order in cygwin.din. Sorry to have to impose this burden on you. >> No, that's fine; I've never been sure whether we need to care about the >> ordinal numbers or not in that file. (AFAIK, we don't have any realistic >> scenarios where anyone would be linking against the Cygwin DLL by ordinal >> imports, but I hate making assumptions based only on my own limited >> experience...) > > It never even occurred to me about ordinal numbers but since I've been > reorganizing that file for years I guess it hasn't been a problem.
I checked. Something somewhere sorts all the exports it turns out, so they all get ordinals assigned in alphanumeric sort order anyway, regardless of cygwin.din order. So, I ended up committing it like so: > Index: winsup/cygwin/cygwin.din > =================================================================== > RCS file: /cvs/src/src/winsup/cygwin/cygwin.din,v > retrieving revision 1.224 > diff -p -u -r1.224 cygwin.din > --- winsup/cygwin/cygwin.din 19 Jul 2010 18:22:40 -0000 1.224 > +++ winsup/cygwin/cygwin.din 11 Sep 2010 06:44:11 -0000 > @@ -453,10 +453,29 @@ fdopen SIGFE > _fdopen = fdopen SIGFE > _fdopen64 = fdopen64 SIGFE > fdopendir SIGFE > +_fe_dfl_env DATA > +_fe_nomask_env DATA > +feclearexcept NOSIGFE > +fedisableexcept NOSIGFE > +feenableexcept SIGFE > +fegetenv NOSIGFE > +fegetexcept NOSIGFE > +fegetexceptflag NOSIGFE > +fegetprec NOSIGFE > +fegetround NOSIGFE > +feholdexcept SIGFE > +_feinitialise NOSIGFE > feof SIGFE > _feof = feof SIGFE > +feraiseexcept SIGFE > ferror SIGFE > _ferror = ferror SIGFE > +fesetenv SIGFE > +fesetexceptflag SIGFE > +fesetprec NOSIGFE > +fesetround NOSIGFE > +fetestexcept NOSIGFE > +feupdateenv SIGFE > fexecve SIGFE > fflush SIGFE > _fflush = fflush SIGFE Otherwise, committed as posted. cheers, DaveK