On 01/14/2013 05:31 PM, Pascal Obry wrote:
> I'd like to have this ability too. I would propose this feature
> triggered by a config option. This way people not liking this won't be
> bothered.
>
> I'm not on IRC and cannot tell, but I don't see why with an option it
> should bother current users.
Hi,
For me the entire point of the lighttable view is to get an overview of
all images, and the ratings are an essential part of this. I certainly
don't think it creates clutter.
This was one of the first changes I made to darktable to make it usable
for me. My simple patch to the dt_view_image_expose() function below
will display the rating for all images. I use green color to make the
stars even more visible.
diff --git a/src/views/view.c b/src/views/view.c
index a1d38bb..dc6896d 100644
--- a/src/views/view.c
+++ b/src/views/view.c
@@ -864,7 +864,6 @@ dt_view_image_expose(
dt_mipmap_cache_read_release(darktable.mipmap_cache, &buf);
const float fscale = fminf(width, height);
- if(imgsel == imgid || full_preview)
{
// draw mouseover hover effects, set event hook for mouse button down!
*image_over = DT_VIEW_DESERT;
@@ -888,6 +887,27 @@ dt_view_image_expose(
else y = .12*fscale;
gboolean image_is_rejected = (img && ((img->flags & 0x7) == 6));
+ if (img)
+ {
+ int rating = (img->flags & 0x7);
+ if (rating > 0 && rating < 6)
+ {
+ for(int k=0; k<rating; k++)
+ {
+ if(zoom != 1)
+ x = (0.41+k*0.12)*width;
+ else
+ x = (.08+k*0.04)*fscale;
+
+ const float STAR_COLOR = 0.7;
+ cairo_set_source_rgb(cr, 0, STAR_COLOR, 0);
+ dt_view_star(cr, x, y, r1, r2);
+ cairo_fill_preserve(cr);
+ cairo_stroke(cr);
+ }
+ }
+ cairo_set_source_rgb(cr, outlinecol, outlinecol, outlinecol);
+ }
if(img) for(int k=0; k<5; k++)
{
if(zoom != 1) x = (0.41+k*0.12)*width;
Regards,
/Daniel
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
