Johannes, > never used lightroom, so can't comment on the functionality, but this: > > https://github.com/darktable-org/darktable/blob/master/src/develop/lightroom.c#L42 > > is probably a bug (static char makes the function not thread-safe, and > in dt everything is multithreaded, just get rid of the static?).
Not sure. This routine is used when we enter the darkroom to check if it exists a Lightroom XML and then create a button for the import. During this I don't think there is thread in action. Right? It is also use to get the xmp file name when clicking on the [Lr] import button. Again I think that this callback will never be run concurrently. Right? -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
