oh, also a not on module versions. first, you're including headers for separately compiled modules in the main compilation unit (libclipping.so and libdarktable.so have now some overlap).
this will totally crash if a module increases it's version, changes the parameters, and is just copied into the /usr/lib/darktable/plugins directory (as it happens all the time when switching back and forth between git/released version). modules come with a version that you might be able to check, but including the (possibly wrong) header might mess with that. so i'm unsure at this point the infrastructure will hold up for a long time. inside dt, accessing the parameters semantically would need boucman's lua type system i guess. the other clean way would be a script to create xmp files with dt parameters for those modules with a given version number (dt will convert them to the newer versions internally). i guess that could, for convenience, still be bound to a button in darktable that just creates that xmp and reads it back in. -jo On Thu, Jan 17, 2013 at 9:43 AM, johannes hanika <[email protected]> wrote: > hey, > > never used lightroom, so can't comment on the functionality, but this: > > https://github.com/darktable-org/darktable/blob/master/src/develop/lightroom.c#L42 > > is probably a bug (static char makes the function not thread-safe, and > in dt everything is multithreaded, just get rid of the static?). > > -jo > > On Thu, Jan 17, 2013 at 8:20 AM, Pascal Obry <[email protected]> wrote: >> >> I have just push some more support for Lightroom import. >> >> We have at the moment: >> >> - crop & flip >> - vignette >> - grain >> - black level >> - tags >> >> If there is needs for other support I'll be glad to work on it but at >> the moment I think we have good support for the next release. >> >> It has been suggested that the Lightroom TSL could be mapped to the >> "color zones" iop. Probably possible, we will see if there is demands. >> >> Anyway, please if you have used Lightroom at some point you report >> issues with the current support. >> >> Thanks. >> >> -- >> Pascal Obry / Magny Les Hameaux (78) >> >> The best way to travel is by means of imagination >> >> http://v2p.fr.eu.org >> http://www.obry.net >> >> gpg --keyserver keys.gnupg.net --recv-key F949BD3B >> >> ------------------------------------------------------------------------------ >> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery >> and much more. Keep your Java skills current with LearnJavaNow - >> 200+ hours of step-by-step video tutorials by Java experts. >> SALE $49.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122612 >> _______________________________________________ >> darktable-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/darktable-devel ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
