On Thu, Jan 17, 2013 at 9:54 AM, Pascal Obry <[email protected]> wrote: > > Johannes, > >> never used lightroom, so can't comment on the functionality, but this: >> >> https://github.com/darktable-org/darktable/blob/master/src/develop/lightroom.c#L42 >> >> is probably a bug (static char makes the function not thread-safe, and >> in dt everything is multithreaded, just get rid of the static?). > > Not sure. This routine is used when we enter the darkroom to check if it > exists a Lightroom XML and then create a button for the import. During > this I don't think there is thread in action. Right? > > It is also use to get the xmp file name when clicking on the [Lr] import > button. Again I think that this callback will never be run concurrently. > Right?
even if it's not at the moment.. i can totally see someone else hacking a back-converter for example, and just using it (and then wondering why it breaks). why not just put it on the stack, doesn't cost us really. -jo ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
