Ilja Booij <[EMAIL PROTECTED]> said: > Ilja Booij wrote: > > > > Aaron Stone wrote: > > [snip] > > > > > > I'm going to release a new RC today. I'd like to add the new column > > (is_header) to the messageblks table, just to be prepared for it. We can > > then add the code to use it later, without having to change the database > > structure. > > I might make sense to also add an index right away, because we're also > going to need that later on. > > INDEX messageblk_physmsg_isheader_idx(physmessage_id, isheader) > > Ilja >
Sounds good... 2.0 is so close, I already bought the beer to celebrate :-) If anybody else has any additional fields that were discussed on the list, but weren't added because the didn't come with code, speak up! If we have a clear plan to add the code during 2.0.x point releases, the columns should go in. For the future, I've been thinking that there should be an automated upgrade program, or at least some feature of dbmail-maintenance to ensure that the tables are well formed for the current release. Once there's code to understand the is_header flag, we'll need an upgrade program that cycles through the database and adds the flag to earlier messages. I think it would be better to do off-line than to do as part of message retrieval; the way that dbmail-imapd recalculates rfcsize on the fly in several different places in the ic_fetch function is an anti-pattern. Aaron --
