Paul J Stevens wrote:
Oops. Message retrieval is broken in this patch. Don't use it just yet.
I'll start the release (of the RC) process now, without this patch. Of
course, the database change (is_header flag) does go in.
boyohboy, _ic_fetch sure is butt-ugly :-)
Spot on. The whole imapcommands.c file is quite ugly. Long functions
which do to much.. I tend to like short and well defined functions better.
I'm not the only one.. From the Linux kernel coding guidelines:
"
Functions
Functions should do only one thing and do it well. They should be short
and hopefully contain only one or two screens of text. If you have a
function that does a lot of small things for different cases, it is
acceptable to have a longer function. But if you have a long, complex
function, you have a problem.
In addition, a large number of local variables within a function is a
measure of how complex the function is. If the number of local variables
exceeds ten, then there is something wrong.
"
imapcommands.c, pop3.c and some other source files with large functions
should be rewritten to make them more maintainable. I guess I'll handle
some of the rewriting, but only after releasing 2.0
Ilja
