On Wednesday 07 August 2013 22:13:49 you wrote: > For example, one fix that comes to mind is to change the line in the > first patch: > > char* soundfont_paths = > "/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2"; > > to this: > > char* soundfont_paths = > SDL_strdup("/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3 > _GM.sf2"); > > What do you think? Feels less intrusive than having a second patch.
ok to reduce the number of patches. But the SDL_strdup solution is needlessly complicated and will probably have some eyebrows raised very high in the future. I'd rather see bug-718129-rm-bad-free.patch merged into bug-715461- soundfont_paths.patch so as to have one simple, correct patch. All the best
signature.asc
Description: This is a digitally signed message part.