Hello Helmut, On 17/11/2014 20:11, Helmut Grohne wrote: > Hi Jean Baptiste, > > On Sun, Nov 16, 2014 at 06:12:56PM +0100, Jean Baptiste Favre wrote: > > I had a look on it during Debian BSP in Paris. > > Thanks for fixing RC bugs! > > > Problem is located into ola-rdm-test.postinst script: > > - It uses debconf, for variable ola-rdm-tests/daemon, without providing > > any template file > > - It uses db_get and never db_input, thus ola-rdm-tests/daemon is > never set > > - debconf is not mentioned as dependency > > > > Please find attached a patch which removes debconf usage from postinst > > script. > > I looked into this patch in more detail now and am willing to sponsor > your NMU (which has been approved by Wouter by now). Unfortunately, this > is not the only serious issue in ola-rdm-tests. In order to avoid > multiple round-trips through the release team I advise /not/ to upload > this fix as is (or at least only request an unblock after fixing the > remaining issues). > > Your patch enables ola-rdm-tests to be installed. This is great and it > enables us to remove it again. Unfortunately, after removing and purging > /etc/defaults/ola-rdm-tests remains. The package fails to clean up after > itself. > > Please try to improve on your patch to cover this case as well. Please > try to use the tool piuparts to verify that this issue and potentially > more problems are indeed fixed by your improved patch. When you submit a > new patch, please Cc me and attach a .debdiff like you did here. If > anything of the above is unclear, please ask.
Thanks for your advice. I'm working on a new version of the patch. In the meantime, what should I do with my already uploaded NMU (on mentors.debian.net). Maybe I should delete it just to be sure nobody will upload it ? I also noticed that init scripts ask for "dpkg-reconfigure package" to enable service start, which is disabled by default. I guess this was OK when debconf handles /etc/default/package content, but obviously it won't work anymore. I can change the init script to display another message. Finally, I'm considering shipping /etc/default/ola which is not shipped currently, in the same way as /etc/default/ola-rdm-tests. It controls whether olad service is enabled or not. And, last question, speaking about /etc/default files, I wonder which are the best practices: - name /etc/default/xxx file according to the init script which will use them - name /etc/default/xxx file according to the package which provide them In my case, /etc/default/ola is provided by ola package but controls olad service. Same with /etc/default/ola-rdm-tests which is provided by eponym package to control rdm_test_server service. All these would indeed increase the overall package quality, but I wonder if this is not a bit "out of scope" work considering Jessie freeze. Regards, Jean Baptiste
signature.asc
Description: OpenPGP digital signature
