On 2016-08-09 21:29, Jochen Sprickerhof wrote:
Hi Daniele,
* Daniele E. Domenichelli <ddomeniche...@drdanz.it> [2016-08-09 20:03]:
I suppose this should be done to all the ros-*-msgs packages, right?
Yes :).
I already have a patch for ros-std-msgs, you can find it here:
https://github.com/drdanz/ros-std-msgs/commit/41dcc24cd3a654e612a33e16e5442bf276d861fe
I've added some comments.
Thanks! I replied to the comments on github, anyway I'm reporting the
everything here:
--- a/debian/changelog
+++ b/debian/changelog
[...]
You don't need to add this, git-buildpackage will take care of it.
Cool, I didn't know about this! I think this mean that I have to amend
the commit and add (Closes: #833383) to the commit log, right?
--- a/debian/control
+++ b/debian/control
[...]
-Depends: ${misc:Depends}, ros-message-runtime
+Depends: ${misc:Depends}, ros-message-runtime,
+ ros-std-msgs (= ${source:Version})
Why do they depend on it?
--- /dev/null
+++ b/debian/ros-std-msgs.install
@@ -0,0 +1 @@
+usr/share/std_msgs
I'm not sure here, it includes the cmake and package.xml file.
Shouldn't they be part of the libstd-msgs-dev?
I added the dependency for the CMake files, but perhaps it's just enough
to move the .msg files only and remove the dependency.
find_package(std_msgs) will fail anyway without ros-message-runtime, so
I should probably move them back.
It would be useful to be able to do something similar anyway, perhaps
find_package(std_msgs COMPONENTS messages), but I think the CMake files
are generated and are supposed to be used with catkin and I don't know
much about it. Suggestions?
Perhaps I'll just add a Findstd_msgs.cmake to my projects...
I would propose to attach the patch to this bug (by mail), so we can
discuss the details.
Attached you will find the 2nd version of the patch.
I moved the CMake files and the package.xml files back to the original
package, removed the dependencies, and reverted the changes to the
changelog file.
If you want, you can register to alioth.debian.org
and request membership to the debian-science group, so you get direct
commit access to our repos.
Actually I'm already registered and member of the debian-science group,
I'm not sure of which permissions I have on the repositories though.
perhaps when the patch is ready I can try pushing it...
Cheers,
Daniele
From: "Daniele E. Domenichelli" <ddomeniche...@drdanz.it>
Date: Wed, 10 Aug 2016 09:45:18 +0200
Subject: Move message definitions in ros-std-msgs package. (Closes #833383)
---
debian/control | 11 +++++++++++
debian/libstd-msgs-dev.install | 3 ++-
debian/ros-std-msgs.install | 1 +
3 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 debian/ros-std-msgs.install
diff --git a/debian/control b/debian/control
index 076e496..db63bfa 100644
--- a/debian/control
+++ b/debian/control
@@ -11,6 +11,17 @@ Homepage: http://wiki.ros.org/std_msgs
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=debian-science/packages/ros/ros-std-msgs.git
Vcs-Git: git://anonscm.debian.org/debian-science/packages/ros/ros-std-msgs.git
+Package: ros-std-msgs
+Section: devel
+Architecture: all
+Depends: ${misc:Depends}
+Description: Message definitions for Standard Robot OS Messages
+ This package is part of Robot OS (ROS). It contains message
+ definitions for the ROS std_msgs library, which contains wrappers for
+ ROS primitive types, which are documented in the msg specification. It
+ also contains the Empty type, which is useful for sending an empty
+ signal.
+
Package: libstd-msgs-dev
Architecture: all
Depends: ${misc:Depends}, ros-message-runtime
diff --git a/debian/libstd-msgs-dev.install b/debian/libstd-msgs-dev.install
index 83f650b..7d5df8e 100644
--- a/debian/libstd-msgs-dev.install
+++ b/debian/libstd-msgs-dev.install
@@ -1,3 +1,4 @@
usr/include
-usr/share/std_msgs
+usr/share/std_msgs/cmake
+usr/share/std_msgs/package.xml
usr/lib/*/pkgconfig/std_msgs.pc usr/lib/pkgconfig
diff --git a/debian/ros-std-msgs.install b/debian/ros-std-msgs.install
new file mode 100644
index 0000000..5bf1da8
--- /dev/null
+++ b/debian/ros-std-msgs.install
@@ -0,0 +1 @@
+usr/share/std_msgs/msg
