On 2023-04-08, Diederik de Haas wrote: > On Saturday, 8 April 2023 04:24:10 CEST Vagrant Cascadian wrote: >> On 2023-04-08, Diederik de Haas wrote: >> I had intended to test a few different versions to see how they were >> affected before moving forward with that... but I did not get around to >> it and we are now very late in the freeze. >> >> If it proves harmless on the version of u-boot in bookworm (2023.01*) >> and bullseye (2021.01*), and if we are being really careful, buster >> (2019.01*) ... then I think it would be good to consider for bookworm, >> or maybe the first bookworm point release? > > Anyway, the goal is to make it configurable in u-boot-menu and it would be > better to keep the default behavior as it was. > A new/better default could be considered for Trixie. > > I've updated the MR and attached the updated patch which only makes the > 'prompt' value a variable (with a default of '0').
I've tested u-boot-menu 4.2.2, which contains your patch applied, and at least on the pinebook-pro it works correctly with u-boot 2023.04 (with both U_BOOT_PROMPT=0 and U_BOOT_PROMPT=1) and does not break u-boot 2023.01 (although that version effectively ignores any setting, always behaving as if U_BOOT_PROMPT=1). So at least for versions of u-boot shipped in bookworm or newer, it does not appear to cause problems. Would be good to try the versions from bullseye and buster at some point, but my hunch is it will be fine. The only problem I would expect is with arbitrary vendor forks of u-boot which may or may not have changed the code. live well, vagrant
signature.asc
Description: PGP signature
