Package: u-boot-menu
Version: 4.2.1
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
As the subject says, u-boot-menu doesn't show a (boot) menu as the
'prompt' setting has a hardcoded value of '0'. If you'd change that to
say '5' then you do see a menu from which you can choose.
But the next time you'd run 'u-boot-update' that value gets overwritten.
https://salsa.debian.org/debian/u-boot-menu/-/merge_requests/13 is my MR
to make the 'prompt' value configurable with a default value of '5'.
It would be great if this could still make it into Bookworm and I do
believe this is a targeted fix. I set 'Severity: normal', but a case can
be made for a higher severity as 'u-boot-menu' doesn't show a menu.
I'd be also fine with a default value of '0', so that the only change
would be to make 'prompt' configurable.
I'll also attach the patch of MR 13 as a patch file.
- -- System Information:
Debian Release: 12.0
APT prefers testing-security
APT policy: (990, 'testing-security'), (990, 'testing'), (500, 'unstable')
Architecture: arm64 (aarch64)
Kernel: Linux 6.1.0-7-arm64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_CRAP
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages u-boot-menu depends on:
ii linux-base 4.9
u-boot-menu recommends no packages.
Versions of packages u-boot-menu suggests:
pn flash-kernel <none>
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZDCVcQAKCRDXblvOeH7b
buLOAP9yKZNz0+Vfk+Y186OcFVIpetwPWIr+XFEw8IVAFLs17QEA7OHU0vY4KWFs
1Wh7DR5LuMimmcbIQcKjxRz3Fdt/wQc=
=uIwT
-----END PGP SIGNATURE-----
>From 382c1e20b0809d5dd9dcba757e574b4bfbcca0dc Mon Sep 17 00:00:00 2001
From: Diederik de Haas <didi.deb...@cknow.org>
Date: Thu, 6 Apr 2023 18:10:12 +0200
Subject: [PATCH] u-boot-update: Make 'prompt' configurable with default value
of 5
The 'prompt' value was hard-coded to 0, which means the menu isn't
actually shown, thereby losing its function as a 'menu' list from which
the user can choose from.
So create an `U_BOOT_PROMPT` variable to make it configurable and set
the default value to 5, so the menu is actually shown and the user can
make a choice from the menu.
---
debian/changelog | 6 ++++++
default | 1 +
u-boot-update | 3 ++-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 5192c3a..cf371ca 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+u-boot-menu (4.2.2) UNRELEASED; urgency=medium
+
+ * u-boot-update: Make 'prompt' configurable with default value of 5
+
+ -- Diederik de Haas <didi.deb...@cknow.org> Thu, 06 Apr 2023 18:08:55 +0200
+
u-boot-menu (4.2.1) unstable; urgency=medium
* Revert "add kalsrseed support" (Closes: #1025954)
diff --git a/default b/default
index 2e29c83..1d17be7 100644
--- a/default
+++ b/default
@@ -4,6 +4,7 @@
#U_BOOT_ALTERNATIVES="default recovery"
#U_BOOT_DEFAULT="l0"
+#U_BOOT_PROMPT="5"
#U_BOOT_ENTRIES="all"
#U_BOOT_MENU_LABEL="Debian GNU/Linux"
#U_BOOT_PARAMETERS="ro quiet"
diff --git a/u-boot-update b/u-boot-update
index 90c4087..c726c9e 100755
--- a/u-boot-update
+++ b/u-boot-update
@@ -96,6 +96,7 @@ fi
U_BOOT_ALTERNATIVES="${U_BOOT_ALTERNATIVES:-default recovery}"
U_BOOT_DEFAULT="${U_BOOT_DEFAULT:-l0}"
+U_BOOT_PROMPT="${U_BOOT_PROMPT:-5}"
U_BOOT_ENTRIES="${U_BOOT_ENTRIES:-all}"
U_BOOT_TIMEOUT="${U_BOOT_TIMEOUT:-50}"
U_BOOT_MENU_LABEL="${U_BOOT_MENU_LABEL:-${PRETTY_NAME:-Debian GNU/Linux
kernel}}"
@@ -162,7 +163,7 @@ _CONFIG="\
default ${U_BOOT_DEFAULT}
menu title U-Boot menu
-prompt 0
+prompt ${U_BOOT_PROMPT}
timeout ${U_BOOT_TIMEOUT}
"
--
2.40.0
