On 2023-04-08, Diederik de Haas wrote:
> As the subject says, u-boot-menu doesn't show a (boot) menu as the
> 'prompt' setting has a hardcoded value of '0'. If you'd change that to
> say '5' then you do see a menu from which you can choose.
> But the next time you'd run 'u-boot-update' that value gets overwritten.

Old versions of u-boot basically ignore this value in my experience, but
that bug was fixed in upstream u-boot 2023.04:

  
https://source.denx.de/u-boot/u-boot/-/commit/739e8361f3fe78038251216df6096a32bc2d5839


> It would be great if this could still make it into Bookworm and I do
> believe this is a targeted fix. I set 'Severity: normal', but a case can
> be made for a higher severity as 'u-boot-menu' doesn't show a menu.
> I'd be also fine with a default value of '0', so that the only change
> would be to make 'prompt' configurable.

The version of u-boot in bookworm (2023.01) should not be affected, so
it is somewhat less urgent... or are you experiencing this issue with
u-boot as shipped in bookworm?

Before changing the default behavior, I was thinking of proposing a
patch for bookworm that kept the current behavior but allowed overriding
it... that would at least be reasonably cautious.

I had intended to test a few different versions to see how they were
affected before moving forward with that... but I did not get around to
it and we are now very late in the freeze.

If it proves harmless on the version of u-boot in bookworm (2023.01*)
and bullseye (2021.01*), and if we are being really careful, buster
(2019.01*) ... then I think it would be good to consider for bookworm,
or maybe the first bookworm point release?


Thanks for submitting the patch and merge request!

> diff --git a/u-boot-update b/u-boot-update
> index 90c4087..c726c9e 100755
> --- a/u-boot-update
> +++ b/u-boot-update
> @@ -96,6 +96,7 @@ fi
>  
>  U_BOOT_ALTERNATIVES="${U_BOOT_ALTERNATIVES:-default recovery}"
>  U_BOOT_DEFAULT="${U_BOOT_DEFAULT:-l0}"
> +U_BOOT_PROMPT="${U_BOOT_PROMPT:-5}"
>  U_BOOT_ENTRIES="${U_BOOT_ENTRIES:-all}"
>  U_BOOT_TIMEOUT="${U_BOOT_TIMEOUT:-50}"
>  U_BOOT_MENU_LABEL="${U_BOOT_MENU_LABEL:-${PRETTY_NAME:-Debian GNU/Linux 
> kernel}}"

My only question here is why "5" vs. say, "1"? I *think* it is
effectively a zero/non-zero boolean.


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature

Reply via email to