Package: topgit Version: 0.5-1 Followup-For: Bug #513952 Hi Martin,
I finally got around to dive into TopGit with CDBS. And was hurt by this bug. Attached is the cdbs snippet that I wrote for my own use. I prefer declaring that I use TopGit. This has the benefit over Stefanos approach of including patchsys-quilt.mk that if you ever restructure to not need quilt, then we (in principle) need no changes to each package. Please consider shipping the attached CDBS snippet with topgit: 1) install it as /usr/share/cdbs/1/topgit.mk 2) have the binary "topgit" package suggest cdbs Including my proposed snippet does not exactly solve this bug, but it turns it into a less severe one: CDBS use majuscles (capital letters) for variables allowed to be changed and minuscles for "internal" variables (i.e. possibly shared across snippets but not for the packages to redefine). The current need for the topgit.mk snippet to declare PATCHES_DIR is confusing as it might wrongly be seen as an invitation for overriding. ...you should probably have the package suggest quilt as well, but that really is a separate issue - and I am too eager to play some more with TopGit to file a separate bugreport about it :-P Kind regards, - Jonas -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.28-1-amd64 (SMP w/2 CPU cores) Locale: LANG=da_DK.UTF-8, LC_CTYPE=da_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages topgit depends on: ii git-core 1:1.6.1.3-1 fast, scalable, distributed revisi topgit recommends no packages. topgit suggests no packages. -- no debconf information
# -*- mode: makefile; coding: utf-8 -*- # Copyright © 2009 Jonas Smedegaard <d...@jones.dk> # Description: let Handle patches using TopGit and quilt # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Software Foundation; either version 2, or (at # your option) any later version. # # This program is distributed in the hope that it will be useful, but # WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU # General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA # 02111-1307 USA. _cdbs_scripts_path ?= /usr/lib/cdbs _cdbs_rules_path ?= /usr/share/cdbs/1/rules _cdbs_class_path ?= /usr/share/cdbs/1/class ifndef _cdbs_rules_topgit _cdbs_rules_topgit = 1 include $(_cdbs_rules_path)/patchsys-quilt.mk$(_cdbs_makefile_suffix) # Currently TopGit is not used in any policy-specified build targets #CDBS_BUILD_DEPENDS := $(CDBS_BUILD_DEPENDS), topgit # These are hardcoded!! # TODO: convince patchsys-quilt.mk and tg2quilt.mk to use our variables PATCHES_DIR := $(DEB_PATCHDIRS) QUILT_STAMPFN := debian/stamp-patched include /usr/share/topgit/tg2quilt.mk endif
