Clint Byrum wrote:
> As promised,
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592652
Thanks. In fact, I had a look already, and I managed to use it to create
an improved version for your sqlite / sqlite3 test which doesn't need
the external debian/run_test.sh (or whatever you called it) script. FYI:
test-stamp: build-stamp
$(MAKE) -C tests test_dbi
# Testing sqlite and sqlite3
TMPDIR= $(shell mkdir -d)
( echo ./drivers/sqlite3/.libs; \
echo sqlite3; \
echo $(TMPDIR); \
echo libdbitest; ) | ./tests/test_dbi
rm -rf $(TMPDIR)
TMPDIR= $(shell mkdir -d)
( echo ./drivers/sqlite/.libs; \
echo sqlite; \
echo $(TMPDIR); \
echo libdbitest; ) | ./tests/test_dbi
rm -rf $(TMPDIR)
As you see, there's no need to use cd or /bin/echo or even /bin/sh. It's
a lot cleaner this way.
Now, I'd like to do more or less the same with the mysql tests. But in
fact, I'm not sure yet we really want to add these MySQL and Postgress
tests: this has a lot of chances to fail in many ways: for example if
someone has configured the mysql/postgress server in a way that your
test wouldn't like, or if something else is binding on the same port and
on 127.0.0.2. By the way, why did you think we need to have MySQL bind
on an IP? Can't we just do a --skip-networking or something, so that the
tests are just using the socket files? If that was the case, then I
think it would be a lot more safe to leave the MySQL test. I didn't have
time to look into the postgresql tests, but I believe that might be the
same issue here.
>> Oh ok. That's a new stuff then, and I didn't use it before. I'd be happy
>> to try, it seems a nice tool.
>>
>
> I haven't implemented it for any packages yet, but a few that I've been
> involved
> with could certainly benefit.
I did use dh_autoreconf and dh_autoreconf_clean thanks to the help of
it's maintainer on IRC (in #debian-devel). It works really great, I have
to admit. So I went ahead and I am now using the 3.0 source format,
which is great! Thanks for pointing it to me.
I'm currently having a look to the MySQL and Postgresql tests as you
sent me.
Thomas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
