Clint Byrum wrote:
> It works great. I installed from those binaries, tested it with rrdtool,
> libdbi 0.8.2 and 0.8.3, and all is well.
Cool !
> I did get a failure on rebuilding on a (mostly updated) debian squeeze box:
>
> SUCCESS! All done, disconnecting and shutting down libdbi. Have a nice day.
>
> kill: 74: Illegal number: /tmp/tmp.W6j2ka26px
> LOG: received smart shutdown request
> make: *** [test-stamp] Error 2
> LOG: autovacuum launcher shutting down
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>
> Because of the set -e, that kill snafu prematurely ended test_pgsql.sh.
> That kill is unnecessary, and can be replaced with
>
> $BINDIR/pg_ctl stop -D ${MYTMPDIR}
>
> Which more or less does the same thing.
Ok, I'll add it then.
> One final issue, I think the two test_XXX scripts should be tagged with a
> license and copyright notices, to remove any ambiguity. Generally shell
> scripts are pretty trivial and I wouldn't care, but these really are not
> trivial at all.
>
> I'd expect you'd also want your copyright to be added there as well, as this
> was
> really done collaboratively. Of course, that is entirely up to you. I'm more
> concerned about making sure the file is clearly licensed than who is
> attributed
> as copyright holder(s).
>
> Its not a huge deal, but I think it ensures nobody will have to wonder about
> the licensing status of the files, which is especially helpful if upstream
> wants
> to incorporate them for their releases.
>
> patch attached...
I agree completely on the licensing of these scripts, however, I don't
see why we would write "Copyright (C) 2010 Canonical, Ltd.". Are you
working for Canonical? I don't. I've got nothing to do with Canonical at
all, they wont own the copyright of things I do. In this case, the
copyrights holders are you and me. So this should be:
Copyright (C) 2010 Clint Byrum <cl...@ubuntu.com>
Copyright (C) 2010 Thomas Goirand <z...@debian.org>
If you have nothing to object to the above, this is what I will write.
Then I'll attach the scripts and I hope that Markus can add them in his
upstream source code.
Thomas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
