OoO En cette fin de nuit blanche du jeudi 24 mars 2011, vers 06:19, Teodor MICU <mteo...@gmail.com> disait :
>>> Please do not modify the upstream file 'iniset.php'. >> >> The modification is done because $_SERVER['SCRIPT_FILENAME'] may >> dereference symlinks and result in /usr/share/roundcube instead of >> /var/lib/roundcube. Some features won't work then (because >> /usr/share/roundcube is not complete). > I've tested this yesterday and re-tested this now by creating a file > 'index2.php' with this content: > <?php > require_once 'program/include/iniset.php'; > echo $_SERVER['SCRIPT_FILENAME']; > echo '<br>'; > echo INSTALL_PATH; > ?> > The result is: > /var/lib/roundcube/index2.php > /var/lib/roundcube/ > I'm using roundcube with the upstream 'iniset.php' with no problems. SCRIPT_FILENAME may be set by a lot of components. It is set by Apache if you use mod_php, set by PHP if you use FPM, etc. I did not find an authoritative source if SCRIPT_FILENAME should or should not follow symlinks. I don't remember why we created this patch but I suppose this was a useful once. Romain, did you remember why you put this patch? >> I don't quite understand what you try to do. Do you copy the roundcube >> installation into another location? > I've cloned '/var/lib/roundcube' (with rsync) on a different directory > in /var/www for a new virtual host designed only for mobile devices > (smart phones). Afterwards I just changed a few symbolic links > (config/main.inc.php, logs) and added a new skin. But for this to work > I had to change the iniset.php to detect automatically INSTALL_PATH. > I hope this explains the setup. I don't want to duplicate roundcube > code if not really necessary. This is a very particular setup. I would like not to break other setups by removing the patch. -- I WILL NOT ENCOURAGE OTHERS TO FLY I WILL NOT ENCOURAGE OTHERS TO FLY I WILL NOT ENCOURAGE OTHERS TO FLY -+- Bart Simpson on chalkboard in episode 7F03
pgpBmgWVcU9Gh.pgp
Description: PGP signature