On Tue, Oct 28, 2008 at 11:44:55PM +0100, Michael Stapelberg wrote:

> > Here we go, this is against -2 in the archive as that's a fixed
> > point. This is only lightly tested, please double-check :)
> I double-checked and added db_stop before #DEBCONF# in mxallowd.postinst to
> avoid hangs on the first start of mxallowd via debconf.

Good catch, don't know how I missed that.

> I hope the rest is correct, please do some final checks for yourself.

I see you still have default IP addresses in mxallowd.templates,
is that intentional? As I said earlier, I don't think guessing
them like that makes sense for noninteractive installations.

> I've released 1.6b which generates pid-files on its own, so start-stop-daemon
> doesn't need to be called with --background and therefore can check the return
> code of mxallowd now.

That's nice, I'm just not sure if it's suitable for Lenny given we're
so deeply frozen. I suppose it might qualify for a severity:important
bugfix that are still allowed.

Your package also has superfluous changes wrt. -2 in the Debian archive:
Makefile is deleted and slides/GPN-05.07.2008/mxallowd.pdf is modified
with no apparent reason. Those are not blockers, but it would be nice
to have a minimal debdiff to review.

Cheers,
-- 
Niko



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to