On Thu, Apr 28, 2016 at 09:58:59AM +0000, Mattia Rizzolo wrote: > On Thu, Apr 28, 2016 at 11:18:23AM +0200, Emmanuel Promayon wrote: > > > WRT this: I saw your comment about not putting --parallel in the default > > > dh invocation; following that comment I explicitly put --no-parallel to > > > be forward compatible with compat level 10 (which defaults to > > > --parallel), but during the build it doesn't seem to use an exaggerate > > > amount of memory, maybe just 3 GB top. IMHO it can be build parallel > > > without any troubles. What architectures did had issues with this? > > > maybe using --max-parallel would be better here instead. > > > > Thanks for the --no-parallel flag. > > > > I removed the --parallel build back in 2013 (commit > > 1b06ed6477e778e3aa448f3bf6a45292fa365673) for camitk-3.2.2-1 as there was > > some "out of memory" error on some architectures when compiling itk filters. > > See [1] (with --parallel on mips) and [2] (without the flag). > > See also bug #747421 [3] > > I see. Bloody mips always causing boring problems. > > > The best might be to try again now with the --parallel option and see if > > some architecture still fail. > > What do you think? > > If there are some failure, would it be then possible to add the > > --max-parallel only for these arch? > > It sure is possible, after all d/rules is just a makefile. > You just do something like the following (if you want to exclude more > archs just use ifeq with findstring). > > I think here you want to check for the build architecture (the arch the > package is built *on*) and not the host architecture (the arch the > package is built *for*) (this can differ if you do a cross compiling). > Most of the checks involving varying build flags between archs is done > checking for the host architecture, but here you just change how you are > going to compile it. I'm no cross build expert, so I can't really say > something definitive, but I'm positive. > See dpkg-architecture(1) for more info. > > DEB_BUILD_ARCH ?= $(shell dpkg-architecture -qDEB_BUILD_ARCH) > ifeq ($(DEB_BUILD_ARCH),mips) > P := --no-parallel > else > P := --parallel > fi > > %: > dh $@ $P
Then, I totally forgot about the fact that itk4 is not available on mips, but only on amd64/i386. Not sure if I'm sad (as that means reducing the supported architectures..) or I'm happy (as that meanst it's easier to support), but hey, a problem less here. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature