Package: release.debian.org User: release.debian....@packages.debian.org Usertags: pu Severity: normal
Hello, so I'm turning this thread into a bug report. My requests are below. More detailed info can be found in the quoted text, individual bug reports and previous mails in the thread. 1) krunner #607974 src:kdebase-workspace. The upload is planned to be identical to the current 4:4.4.5-8 in unstable, just with squeeze-adjusted revision number. 4:4.4.5-8 fared well in unstable, I have never had a single krunner crash since upgrading. 2) src:krusader #604196. All info, including the patch, below and in the bug report. Package revision will be properly squeeze-adjusted. 3) kde4libs #588374. Squeeze upload will be based on kde4libs 4:4.4.5-3 currently in unstable. It solves a desktop "defacing" issues after upgrade from KDE 3 (lenny -> squeeze). Quoting the changelog: * Add a kconf_update script (migrate_from_kde3_icon_theme) to migrate away from old KDE 3 icon themes which are KDE 4 incompatible (e.g. crystalsvg). (Closes: #588374) * Urgency=high, the fix is solely targeted at fixing lenny->squeeze upgrades though it might not get there in time. Let me know if you could pull kdebase-workspace and kde4libs uploads directly from unstable. Or if I can start uploading. On trečiadienis 26 Sausis 2011 02:09:52 Julien Cristau wrote: > On Wed, Jan 19, 2011 at 23:04:31 +0200, Modestas Vainius wrote: > > Hello, > > > > On trečiadienis 19 Sausis 2011 11:18:34 Julien Cristau wrote: > > > On Tue, Jan 18, 2011 at 02:25:34 +0200, Modestas Vainius wrote: > > > > 4) src:krusader #604196 There are reports that the included fix for > > > > this grave bug is wrong. Too bad I would need to do a t-p-u upload > > > > in order to include the supposedly right fix ( > > > > http://websvn.kde.org/?view=revision&revision=1169424 + > > > > http://websvn.kde.org/?view=revision&revision=1169519 ). I will test > > > > it as best as I can. > > > > > > maybe r1 as well. > > > > First of all, some background on the issue: > > > > 1) Before 1:2.2.0~beta1-2 was uploaded, upstream [1] and me [2] had some > > considerations about the fix because it apparently introduced a new > > regression as serious as a crash [3]. To make things worse, #604196 was > > later opened saying that the patch didn't actually fix the bug in the > > end. > > > > 2) QCoreApplication::processEvents() [4] is considered to be a dangerous > > function when called manually. It messes up control flow in unpredictable > > ways as it triggers processing of the event loop right away. It may even > > dead lock an application in the worst case scenario (event loop > > processing from within unfinished event handler, oops). Who knows, maybe > > #604196 is because of event loop deadlock. > > > > The new patch apparently nails and fixes the real cause of the > > hang-on-quit. Of course if there is release process related reasons to > > wait (e.g. it's simply too late for t-p-u at this point), we can delay > > it. But if we could fix it now, we should do it (it's -1 RC bug anyway, > > karma++ :-)). > > I think this can wait for r1, and at this point I'm nervous about more > changes before the release, so I'll defer this. > On Tue, Jan 18, 2011 at 02:25:34 +0200, Modestas Vainius wrote: > > 2) krunner #607974 src:kdebase-workspace. The upstream patch > > http://tinyurl.com/6e6b24l is supposed to fix the crash. There is no time > > to confirm the fix 100% as the crash, while pretty common, is random and > > hard to reproduce reliably. The crash no longer occurs in KDE SC 4.5 (at > > least there no new reports against it upstream) which this patch is > > included in. > > > > I have already experienced the crash more than a dozen times. Whenever > > krunner goes down, it's really annoying as krunner is one of the primary > > UI interfaces for launching new applications in KDE. > > would delaying this to r1 allow to confirm the fix? > > 4) src:krusader #604196 There are reports that the included fix for this > > grave bug is wrong. Too bad I would need to do a t-p-u upload in order to > > include the supposedly right fix ( > > http://websvn.kde.org/?view=revision&revision=1169424 + > > http://websvn.kde.org/?view=revision&revision=1169519 ). I will test it > > as best as I can. > Debdiff of the latter is bellow (#604196 is actually a dupe of #587842, > but the latest discussion is in the former (#604196) bug). I tested & > verified the new patch, it works fine. The patch included in > 1:2.2.0~beta1-2 was wrong, I removed it. > > $ debdiff krusader_2.2.0~beta1-2.dsc krusader_2.2.0~beta1-3.dsc > diff -Nru krusader-2.2.0~beta1/debian/changelog > krusader-2.2.0~beta1/debian/changelog --- > krusader-2.2.0~beta1/debian/changelog 2010-10-09 03:38:41.000000000 > +0300 +++ krusader-2.2.0~beta1/debian/changelog 2011-01-19 > 01:42:58.000000000 +0200 @@ -1,3 +1,11 @@ > +krusader (1:2.2.0~beta1-3) testing-proposed-updates; urgency=high > + > + * Replace rev1154581.patch with > backport_fix_krusader_not_terminating.diff + backported from upstream > svn. It has a proper fix for #587842. + (Closes: #604196) > + > + -- Modestas Vainius <mo...@debian.org> Wed, 19 Jan 2011 01:02:53 +0200 > + > > krusader (1:2.2.0~beta1-2) unstable; urgency=medium > > * Grab upstream rev1154581.patch > > diff -Nru > krusader-2.2.0~beta1/debian/patches/backport_fix_krusader_not_terminating. > diff > krusader-2.2.0~beta1/debian/patches/backport_fix_krusader_not_terminating. > diff --- > krusader-2.2.0~beta1/debian/patches/backport_fix_krusader_not_terminating. > diff 1970-01-01 03:00:00.000000000 +0300 > +++ > krusader-2.2.0~beta1/debian/patches/backport_fix_krusader_not_terminating. > diff 2011-01-19 01:19:05.000000000 +0200 > @@ -0,0 +1,88 @@ > +From: Jan Lepper <deht...@yahoo.de> > +Subject: better fix for Krusader not terminating: create panel popup on > demand +Bug-Debian: http://bugs.debian.org/604196 > +Forwarded: yes > +Origin: backport, svn diff svn://anonsvn.kde.org/home/kde -c 1169424 > + svn diff svn://anonsvn.kde.org/home/kde -c 1169519 > +Last-Update: 2011-01-19 > +Reviewed-By: Modestas Vainius <mo...@debian.org> > + > +--- a/krusader/Panel/listpanel.cpp > ++++ b/krusader/Panel/listpanel.cpp > +@@ -332,13 +332,6 @@ ListPanel::ListPanel(int typeIn, QWidget > + // view > + createView(); > + > +- // popup panel > +- popup = new PanelPopup(splt, left); > +- connect(popup, SIGNAL(selection(const KUrl&)), SLOTS, > SLOT(refresh(const KUrl&))); +- connect(popup, SIGNAL(hideMe()), this, > SLOT(togglePanelPopup())); +- popup->hide(); > +- > +- > + //filter = ALL; > + > + // create the layout > +@@ -497,6 +490,12 @@ bool ListPanel::eventFilter(QObject * wa > + > + void ListPanel::togglePanelPopup() > + { > ++ if(!popup) { > ++ popup = new PanelPopup(splt, left); > ++ connect(popup, SIGNAL(selection(const KUrl&)), SLOTS, > SLOT(refresh(const KUrl&))); ++ connect(popup, SIGNAL(hideMe()), > this, SLOT(togglePanelPopup())); ++ } > ++ > + if (popup->isHidden()) { > + if (popupSizes.count() > 0) { > + > dynamic_cast<QSplitter*>(popup->parent())->setSizes(popupSizes); +@@ > -1234,7 +1233,8 @@ void ListPanel::slotJobStarted(KIO::Job* > + cdUpButton->setEnabled(false); > + cdOtherButton->setEnabled(false); > + popupBtn->setEnabled(false); > +- popup->setEnabled(false); > ++ if(popup) > ++ popup->setEnabled(false); > + bookmarksButton->setEnabled(false); > + historyButton->setEnabled(false); > + syncBrowseButton->setEnabled(false); > +@@ -1287,7 +1287,8 @@ void ListPanel::inlineRefreshListResult( > + cdUpButton->setEnabled(true); > + cdOtherButton->setEnabled(true); > + popupBtn->setEnabled(true); > +- popup->setEnabled(true); > ++ if(popup) > ++ popup->setEnabled(true); > + bookmarksButton->setEnabled(true); > + historyButton->setEnabled(true); > + syncBrowseButton->setEnabled(true); > +@@ -1358,20 +1359,22 @@ void ListPanel::editLocation() > + > + void ListPanel::saveSettings(KConfigGroup &cfg) > + { > +- popup->saveSizes(); > +- cfg.writeEntry(_left ? "Left Panel Popup" : "Right Panel Popup", > popup->currentPage()); ++ if(popup) { > ++ popup->saveSizes(); > ++ cfg.writeEntry(_left ? "Left Panel Popup" : "Right Panel Popup", > popup->currentPage()); ++ } > + } > + > + void ListPanel::updatePopupPanel(KrViewItem *item) > + { > + // which panel to display on? > + ListPanel *lp = 0; > +- if (popup->isHidden() && otherPanel->gui->popup->isHidden()) > +- return; > +- if (!popup->isHidden()) > ++ if(popup && !popup->isHidden()) > + lp = this; > +- else if (!otherPanel->gui->popup->isHidden()) > +- lp = ACTIVE_PANEL->otherPanel->gui; > ++ else if(otherPanel->gui->popup && > !otherPanel->gui->popup->isHidden()) ++ lp = otherPanel->gui; > ++ else > ++ return; > + > + KUrl url; > + if (item->name() != "..") // updir > diff -Nru krusader-2.2.0~beta1/debian/patches/rev1154581.patch > krusader-2.2.0~beta1/debian/patches/rev1154581.patch > --- krusader-2.2.0~beta1/debian/patches/rev1154581.patch 2010-10-09 > 03:38:41.000000000 +0300 +++ > krusader-2.2.0~beta1/debian/patches/rev1154581.patch 1970-01-01 > 03:00:00.000000000 +0300 @@ -1,10 +0,0 @@ > ---- ./krusader/panelmanager.cpp 2010/07/25 23:05:32 1154580 > -+++ ./krusader/panelmanager.cpp 2010/07/25 23:07:11 1154581 > -@@ -121,6 +121,7 @@ > - > - // _stack->setUpdatesEnabled(false); > - _stack->setCurrentWidget(_self); > -+ kapp->processEvents(); > - // make sure the view is focused (this also causes > ListPanel::slotFocusOnMe() to be called) - > _self->view->widget()->setFocus(); > - // _stack->setUpdatesEnabled(true); > diff -Nru krusader-2.2.0~beta1/debian/patches/series > krusader-2.2.0~beta1/debian/patches/series --- > krusader-2.2.0~beta1/debian/patches/series 2010-10-09 03:38:41.000000000 > +0300 +++ krusader-2.2.0~beta1/debian/patches/series 2011-01-19 > 01:22:37.000000000 +0200 @@ -1 +1 @@ > -rev1154581.patch > +backport_fix_krusader_not_terminating.diff -- Modestas Vainius <modes...@vainius.eu>
signature.asc
Description: This is a digitally signed message part.
