Package: release.debian.org Severity: normal Tags: patch User: release.debian....@packages.debian.org Usertags: unblock
Hi, the upstream author of kvpm who also happens to be the Debian maintainer of the package recently found a critical bug when moving partitions [1]. I have reviewed his package and I'm attaching the Debdiff. Please unblock the package for Wheezy. unblock kvpm/0.8.6-3 > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703919 -- System Information: Debian Release: 7.0 APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.8-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru kvpm-0.8.6/debian/changelog kvpm-0.8.6/debian/changelog --- kvpm-0.8.6/debian/changelog 2012-04-16 17:47:32.000000000 +0200 +++ kvpm-0.8.6/debian/changelog 2013-03-27 01:13:57.000000000 +0100 @@ -1,3 +1,11 @@ +kvpm (0.8.6-3) unstable; urgency=critical + + [ Benjamin J. Scott ] + * Changed file kvpm/partchange.cpp to fix potential data corruption bug + when moving a partition on a disk with mounted partitions (Closes: #703919). + + -- Benjamin J. Scott <bensc...@nwlink.com> Sun, 24 Feb 2013 17:25:21 -0700 + kvpm (0.8.6-2) unstable; urgency=low [ Benjamin J. Scott ] diff -Nru kvpm-0.8.6/debian/patches/partition-move-corruption.patch kvpm-0.8.6/debian/patches/partition-move-corruption.patch --- kvpm-0.8.6/debian/patches/partition-move-corruption.patch 1970-01-01 01:00:00.000000000 +0100 +++ kvpm-0.8.6/debian/patches/partition-move-corruption.patch 2013-03-06 07:12:54.000000000 +0100 @@ -0,0 +1,20 @@ +This patch corrects a bug in which data is sometimes corrupted when moving a disk +partition while the disk has other partitions mounted. +--- a/kvpm/partchange.cpp ++++ b/kvpm/partchange.cpp +@@ -649,13 +649,8 @@ + return false; + } + else { +- if( !movefs(old_start, current_start, old_size) ){ +- return false; +- } +- else{ +- pedCommitAndWait(m_ped_disk); +- return true; +- } ++ pedCommitAndWait(m_ped_disk); ++ return movefs(old_start, current_start, old_size); + } + } + diff -Nru kvpm-0.8.6/debian/patches/series kvpm-0.8.6/debian/patches/series --- kvpm-0.8.6/debian/patches/series 2012-04-16 17:41:26.000000000 +0200 +++ kvpm-0.8.6/debian/patches/series 2013-03-06 08:16:15.000000000 +0100 @@ -1 +1,2 @@ +partition-move-corruption.patch bug-667232.patch