+1 for 120
Antoine SABOT-DURAND
Le 12 déc. 2011 à 14:37, Jakob Korherr a écrit :
> 80 is too short nowadays. I'd prefer at least 100, but 120 would be even
> better!
>
> Regards,
> Jakob
>
> 2011/12/12 Shane Bryzak <sbry...@gmail.com>:
>> Looks like the consensus is 4 spaces. One other thing to consider is the
>> line width, in the olden days this was generally 80 characters, however on
>> today's big monitors 100 or even 120 is more typical. Does anyone have any
>> preference here?
>>
>> On Mon, Dec 12, 2011 at 10:54 PM, Mark Struberg <strub...@yahoo.de> wrote:
>>
>>> True, indent size is also important.
>>>
>>> I'm pretty much used to 4.
>>>
>>> Indenting by 3 spaces feels a bit flabby ;)
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>>
>>>
>>>> ________________________________
>>>> From: Shane Bryzak <sbry...@gmail.com>
>>>> To: deltaspike-dev@incubator.apache.org; Mark Struberg <strub...@yahoo.de
>>>>
>>>> Sent: Monday, December 12, 2011 1:30 PM
>>>> Subject: Re: basic decisions - coding conventions
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, Dec 12, 2011 at 9:37 PM, Mark Struberg <strub...@yahoo.de> wrote:
>>>>
>>>> Hi!
>>>>>
>>>>> I'm a fan of a pretty tight coding convention observation even at build
>>> time.
>>>>>
>>>>> What we usually have (in owb and myfaces) is an own 'buildtools' project
>>> which contains the checkstyle rules as own artifact.
>>>>> This will then be used in the deltaspike-parent pom as dependency of the
>>> maven-checkstyle-plugin. I'll set this up, no worries, easy stuff.
>>>>>
>>>>> The more important thing is to decide _which_ coding conventions we like
>>> to follow at all?
>>>>>
>>>>> I have the following suggestions:
>>>>>
>>>>> 1.) no tabs, only spaces!
>>>>>
>>>>
>>>>
>>>> +1, tabs suck
>>>>
>>>>
>>>>
>>>>
>>>>> 2.) bracelets on new line? Actually I don't care about
>>>>>> if()
>>>>>> {
>>>>>> dings();
>>>>>> }
>>>>> or
>>>>>
>>>>>> if() {
>>>>>> dings();
>>>>>> }
>>>>> but we should only use one stile throughout the whole code.
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> I don't mind either way here, comfortable with either as long as we pick
>>> one and are consistent with it.
>>>>
>>>>
>>>>
>>>>
>>>>> 3.) force bracelets
>>>>>
>>>>> no
>>>>>
>>>>>> if()
>>>>>
>>>>>> dosomething;
>>>>>
>>>>> without bracelets. Instead force:
>>>>>> if()
>>>>>> {
>>>>>
>>>>>> dosomething;
>>>>>> }
>>>>>
>>>>>
>>>>
>>>>
>>>> +1
>>>>
>>>>
>>>>> I'm sure there is a bit more, thus please add the rules which are
>>> important for you.
>>>>> (PS: once we found a final solution we should move this into our wiki +
>>> provide Eclipse and Idea checkstyle rules.
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> One thing to decide is indent size. Currently in Seam we use 4 spaces,
>>> as we've recently adopted the JBoss coding standards. Personally, I think
>>> this is a little too much, previously we had 3 spaces (Gavin's preference)
>>> which I thought was better.
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>
>
>
> --
> Jakob Korherr
>
> blog: http://www.jakobk.com
> twitter: http://twitter.com/jakobkorherr
> work: http://www.irian.at
