hi @ all, i created [1] for collecting the suggestions. if you don't like one of the mentioned conventions, add your own suggestion. i'll start a vote about it on monday.
regards, gerhard [1] https://issues.apache.org/jira/browse/DELTASPIKE-12 2011/12/12 Jason Porter <lightguard...@gmail.com> > +1 to 120 > > The rest I'm okay with as well. > > On Mon, Dec 12, 2011 at 11:24, Jason Porter <lightguard...@gmail.com> > wrote: > > > On Mon, Dec 12, 2011 at 04:37, Mark Struberg <strub...@yahoo.de> wrote: > > > >> Hi! > >> > >> I'm a fan of a pretty tight coding convention observation even at build > >> time. > >> > >> What we usually have (in owb and myfaces) is an own 'buildtools' project > >> which contains the checkstyle rules as own artifact. > >> This will then be used in the deltaspike-parent pom as dependency of the > >> maven-checkstyle-plugin. I'll set this up, no worries, easy stuff. > >> > >> The more important thing is to decide _which_ coding conventions we like > >> to follow at all? > >> > >> I have the following suggestions: > >> > >> 1.) no tabs, only spaces! > >> > > +1 > > > > > >> 2.) bracelets on new line? Actually I don't care about > >> > if() > >> > { > >> > dings(); > >> > } > >> or > >> > >> > if() { > >> > dings(); > >> > } > >> but we should only use one stile throughout the whole code. > >> > > +1 > > > > > >> > >> 3.) force bracelets > >> > >> no > >> > >> > if() > >> > >> > dosomething; > >> > > +1 > > > > > >> without bracelets. Instead force: > >> > if() > >> > { > >> > >> > dosomething; > >> > } > >> > >> > >> I'm sure there is a bit more, thus please add the rules which are > >> important for you. > >> (PS: once we found a final solution we should move this into our wiki + > >> provide Eclipse and Idea checkstyle rules. > >> > >> > >> LieGrue, > >> strub > >> > >> > > Line width? Indentation width? > > > > -- > > Jason Porter > > http://lightguard-jp.blogspot.com > > http://twitter.com/lightguardjp > > > > Software Engineer > > Open Source Advocate > > Author of Seam Catch - Next Generation Java Exception Handling > > > > PGP key id: 926CCFF5 > > PGP key available at: keyserver.net, pgp.mit.edu > > > > > > -- > Jason Porter > http://lightguard-jp.blogspot.com > http://twitter.com/lightguardjp > > Software Engineer > Open Source Advocate > Author of Seam Catch - Next Generation Java Exception Handling > > PGP key id: 926CCFF5 > PGP key available at: keyserver.net, pgp.mit.edu >
