[
http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12373839 ]
Knut Anders Hatlen commented on DERBY-924:
------------------------------------------
The patch looks very good. There are however two issues that I would
like to have resolved before I commit the patch.
1) In DatabaseMetaData.getFunctionsX() you have this comment:
// Uncomment the following line when DERBY-970 is committed
// checkServerJdbcVersionX()
Since your patch is likely to get into trunk before my DERBY-970
patch, please copy checkServerJdbcVersionX() into your patch and
enable the check.
2) I liked the way you managed to test JDBC 4.0 functionality in a
test that doesn't require jdk 1.6 to compile and run, but I don't
see any good reason why the methods are invoked only when
jvm>=1.6. That is, I would have removed these lines from
metadata_test.java:
// Make sure the method is available in the interface
Class.forName("java.sql.DatabaseMetaData").
getMethod("getFunctions", a);
With this change, getFunctions() will be tested in JVM 1.4/1.5 as
well, and you don't need to add separate canons for 1.6. Also note
that this change will require you to update
Upgrade_10_1_10_2.out. (Actually, in your current patch you should
have created a jdk16 version of Upgrade_10_1_10_2.out, but that
won't be necessary now.) I ran the upgrade test (jvm 1.5 and 1.6)
with this change, and the diff looked reasonable.
> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
> Key: DERBY-924
> URL: http://issues.apache.org/jira/browse/DERBY-924
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.2.0.0
> Environment: JDK 1.6
> Reporter: David Van Couvering
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff,
> derby-924.v2.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're
> compliant, but we should be able to implement this one
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
