[
https://issues.apache.org/jira/browse/DERBY-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474654
]
Knut Anders Hatlen commented on DERBY-2257:
-------------------------------------------
A couple of questions after a quick look at the patch:
- Does EmbedConnection.lobHashTable need to be a Hashtable, or could it be an
unsynchronized HashMap. The comments say that it is a HashMap, and I think all
uses of it will already be synchronized on the connection object.
- Could EmbedConnection.getIncLOBKey() be made private?
- I think all calls to getIncLOBKey() will be synchronized on
getConnectionSynchronization(), so there should be no need to do explicit
synchronization in that method.
- EmbedConnection.lobHTKey could be private.
- LOBStoredProcedure.getEmbedConnection() could be simplified to: return
(EmbedConnection) DriverManager.getConnection(...);
- BrokeredConnection catches and ignores SQLExceptions. Wouldn't it be better
to declare the methods as "throws SQLException" and let the exception be
handled properly by the caller?
- Comments for ClobStoredProcecedureTest.tearDown() and
BlobStoredProcedureTest.tearDown() say "drop the table and close the
connection", but they don't drop any table.
- tearDown() should call super.tearDown().
- Perhaps the suite() method could mention why the tests only run in embedded
mode?
> Implementing the stored procedures called by the LOB related JDBC methods
> -------------------------------------------------------------------------
>
> Key: DERBY-2257
> URL: https://issues.apache.org/jira/browse/DERBY-2257
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Environment: All environments
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: Expln_StoredProc_LOB.txt, Expln_StoredProc_LOB_v2.txt,
> StoredProcedures_v1.diff, StoredProcedures_v1.stat, StoredProcedures_v2.diff,
> StoredProcedures_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
