[
https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manjula Kutty updated DERBY-3717:
---------------------------------
Attachment: DERBY_3717_07_25_diff.txt
DERBY_3717_07_25_stat.txt
- The try/catch/print code should be removed. Instead, the methods should be
declared as "throws Exception" so that the JUnit framework picks up and reports
the errors correctly.
Done in the recent patch
- We cannot rely on the ordering of the elements in the Properties object.
Changed the code to use Property object
- The indentation still looks strange.
Hope I have the correct indentation now..
- Could makeServerPolicyName() be made static so that decorateWithPolicy()
Done in the recent patch
- In all the test methods, element 0 of expectedValues is set in the for loop
which compares the actual values with the expected values. Why not set element
0 to the correct value when expectedValues is initialized?
Done
- Should the test also be added to derbynet._Suite?
Yes, Added
Please review this patch and let me know if it needs any modification.
> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>
> Key: DERBY-3717
> URL: https://issues.apache.org/jira/browse/DERBY-3717
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.1.4
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt,
> DERBY_3717_07_22_diff.txt, DERBY_3717_07_22_stat.txt,
> DERBY_3717_07_25_diff.txt, DERBY_3717_07_25_stat.txt, DERBY_3717_diff.txt,
> DERBY_3717_stat.txt
>
>
> Place holder to contribute the convered test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
