[
https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622089#action_12622089
]
Myrna van Lunteren commented on DERBY-3717:
-------------------------------------------
I took a look at your patch. My comments:
1- Looks to me like you took care of Kristian's latest review's points b, d,
and e.
2- I think Kristian's point c can be addressed by doing this at the top of
decorateWithPolicy:
String serverPolicyName = makeServerPolicyName();
3- Kristian's point a is indeed tricky. You probably don't need as much as you
have, certainly not as much as is in derby_tests.policy, but more than what is
in the original tests' policy file.
I'd have let this one go, to speed things up, if it was the only point. As it
is, you should
try to minimize the contents of the policy file to only the minimal.
4- you didn't remove the old test from suites.derbynetmats (nor
suites.j9derbynetmats, nor from the DerbyNet*.exclude files that list it as a
test to be skipped).
5 - the other issues are nits or things I could've corrected myself, but the
test doesn't run clean - it leaves stuff behind somewhere. If I run it a second
time without cleaning the directory I get a failure.
The failure I got was this:
1) testPropertiesAfterConnection(org.apache.derbyTesting.functionTests.tests.der
bynet.GetCurrentPropertiesTest)junit.framework.ComparisonFailure: expected:<true
> but was:<null>
at org.apache.derbyTesting.functionTests.tests.derbynet.GetCurrentProper
tiesTest.testPropertiesAfterConnection(GetCurrentPropertiesTest.java:168)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:
104)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at
org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
Did you run suites.All?
> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>
> Key: DERBY-3717
> URL: https://issues.apache.org/jira/browse/DERBY-3717
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.1.4
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt,
> DERBY_3717_07_22_diff.txt, DERBY_3717_07_22_stat.txt,
> DERBY_3717_07_25_diff.txt, DERBY_3717_07_25_stat.txt,
> DERBY_3717_08_11_diff.txt, DERBY_3717_08_11_stat.txt, DERBY_3717_diff.txt,
> DERBY_3717_stat.txt
>
>
> Place holder to contribute the convered test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
