[ 
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tiago R. Espinha updated DERBY-4217:
------------------------------------

    Attachment: DERBY-4217-ij.patch

Attaching possibly the final patch for the ij bit.

The previous patch had an issue. Since I was forcing the port to be 
TestConfiguration.getCurrent().getPort() in a constructor that is widely used 
in other tests, this would break them since they were expecting the port to be 
1527 and not whatever property was specified.

This patch creates an additional constructor specifically for ij that allows 
the port to be customized. Then the test specifies the port as 
getCurrent().getPort.

The suites.All ran fine for this patch when the port property was specified, 
but it gave me the following error when I ran it without the port property:
--------------8<---------------
1) 
testAttributeAccumulatedConnectionCount(org.apache.derbyTesting.functionTests.tests.management.NetworkServerMBeanTest)java.security.PrivilegedActionException:
 javax.management.InstanceNotFoundException: 
org.apache.derby:type=NetworkServer,system=c013800d-0121-94a9-8310-ffff8baa048d
        at java.security.AccessController.doPrivileged(Native Method)
        at 
org.apache.derbyTesting.functionTests.tests.management.MBeanTest.getAttribute(MBeanTest.java:379)
        at 
org.apache.derbyTesting.functionTests.tests.management.NetworkServerMBeanTest.testAttributeAccumulatedConnectionCount(NetworkServerMBeanTest.java:93)
(...)
---------------8<-----------------

I'm thinking that it might be unrelated though, and as so I'm running the 
suites.All again without a port specified.

> Make the default port for the suites.All run configurable with a system 
> property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217-ij.patch, DERBY-4217-ij.patch, 
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, 
> DERBY-4217-ij.stat, DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch, 
> DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat, 
> ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a 
> system property passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to