[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715623#action_12715623
]
Tiago R. Espinha commented on DERBY-4217:
-----------------------------------------
I am now stuck on the ServerPropertiesTest and this test will require some
thought. On this test a derby.properties file is created where a port is
specified; this must be handled with care, because for the test to make sense,
that port must take precedence over the derby.tests.port property.
This test also has a getAlternativePort() method and I am considering the
possibility of getting it to use the TestConfiguration.getAlternativePort()
instead.
Other than this one test, I believe the remaining tests are running fine. My
methodology has been running suites.All and as soon as I have failures, I stop
the run and check the error files to see which tests are failing. Then I fix
those tests and run it again. This is one of the tests that fails right on the
start, so there may still be some tests failing towards the end of the suite.
In the long run we should also debate whether we want a decorator in
TestConfiguration that allows for the port to be customized. If we allow this,
it may be dangerous for concurrent testing. On my current patch for ij we do
have such decorator, but that's necessary evil for incremental patches; it
could be removed when I issue the final derby.tests.port patch.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.stat, DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
