[ 
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tiago R. Espinha updated DERBY-4217:
------------------------------------

    Attachment: DERBY-4217-dtp.patch

Provided that the patch is good (I have been experiencing some oddity regarding 
end of line characters, but nothing serious it seems), this will be the last 
patch for derby.tests.port.

The replication run still had the 1527 port hardcoded in it as the 
masterServerPort, but as Ole suggested, this port is now being set to 
derby.tests.port.

The NetworkServerControlClientCommandTest also had some changes of mine that 
would break should the default port be bound. Nothing big, just the pings when 
no port is supplied to the NetworkServerControl. If no port is supplied, the 
default port (1527) is used, and if there's something listening and replying on 
the 1527 port (the app. I created sends out random replies on connection 
attempts since some tests will wait to hear something), the ping passes and I 
wasn't accounting for that in the Network...CommandTest.

With this latest patch, the replication run and the Network...CommandTest run 
fine, but I have not yet ran the suites.All. I will once more run it with and 
without the 1527 port bound.

Do note that the changes for the replication ports will come in a separate 
patch.

> Make the default port for the suites.All run configurable with a system 
> property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, 
> DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-ij.patch, 
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, 
> DERBY-4217-ij.patch, DERBY-4217-ij.stat, DERBY-4217-ij.stat, 
> DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, 
> DERBY-4217.stat, DERBY-4217.stat, ErrorLog_suitesAll_bound.tgz, 
> ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a 
> system property passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to