[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720408#action_12720408
]
Tiago R. Espinha edited comment on DERBY-4217 at 6/16/09 4:10 PM:
------------------------------------------------------------------
This is a preliminary patch for the idea mentioned before. There's one thing I
don't like about it yet and that's the initialization of the lastAssignedPort.
It's being done on all constructors and that doesn't seem very elegant. On the
other hand, doing a static initialization doesn't work either as I have to
initialize it to TestConfiguration.getCurrent().getPort(). (However, I might
just as well fetch the derby.tests.port property in the initializer...)
This test also contains a change suggested by Kathey - the change of the
property name from derby.tests.port to derby.tests.basePort simply for
clarity's sake as to which port is this.
There's also something I don't understand but it seems to be working and that
is replication. As you can see on the replaced lines on the patch, the
replication ports were initialized statically to 3527 and 6666. Yet, they are
later on changed in initEnvironment() to 4527 and 8888.
The way I went about it was to do the actual assignment in the static
initialization and disregard the other assignments in initEnvironment. Then I
ran the ReplicationSuite and it gave me no errors. I'm doing a suites.All run
with this patch tonight.
was (Author: espinha):
This is a preliminary patch for the idea mentioned before. There's one
thing I don't like about it yet and that's the initialization of the
lastAssignedPort. It's being done on all constructors and that doesn't seem
very elegant. On the other hand, doing a static initialization doesn't work
either as I have to initialize it to TestConfiguration.getCurrent().getPort().
(However, I might just as well fetch the derby.tests.port property in the
initializer...)
This test also contains a change suggested by Katy - the change of the property
name from derby.tests.port to derby.tests.basePort simply for clarity's sake as
to which port is this.
There's also something I don't understand but it seems to be working and that
is replication. As you can see on the replaced lines on the patch, the
replication ports were initialized statically to 3527 and 6666. Yet, they are
later on changed in initEnvironment() to 4527 and 8888.
The way I went about it was to do the actual assignment in the static
initialization and disregard the other assignments in initEnvironment. Then I
ran the ReplicationSuite and it gave me no errors. I'm doing a suites.All run
with this patch tonight.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217-basePort.patch, DERBY-4217-dtap.patch,
> DERBY-4217-dtap.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
> DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.stat,
> DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ErrorLog_suitesAll_bound.tgz, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
