[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720812#action_12720812
]
Kathey Marsden commented on DERBY-4217:
---------------------------------------
Hi Tiago,
Here's some comments on the patch DERBY-4217.basePort.patch.
ReplicationRun:
On line 69, you changed the masterServerPort from getPort() to
getAlternativePort(). Why doesn't getPort() work in this case. Regarding the
previous change of ports in initEnvironment() I don't quite understand why that
was being done. It would be good if someone familiar with replication could
take a look and see if it is ok like you have it or if we need to make yet
another call to getNextAlternativePort() in initEnvironment.
TestConfiguration:
I think in getNextAvailablePort() we should throw an assertion saying something
like "Port x exceeeds expected maximum MAX_PORTS_USED insted of returning -1.
You may need to update MAX_PORTS_USED and the Wiki page at
http://wiki.apache.org/db-derby/DerbyJUnitTesting if test runs now require more
available ports"
Why do we need to create a NetworkServerControl and try to ping if we are
requiring the user allocate enough available ports? This part makes me
especially nervous since it might make DERBY-4053 more likely to hit.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217-basePort.patch, DERBY-4217-dtap.patch,
> DERBY-4217-dtap.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
> DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.stat,
> DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ErrorLog_suitesAll_bound.tgz, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
