[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tiago R. Espinha updated DERBY-4217:
------------------------------------
Attachment: DERBY-4217-basePort.patch
Attaching a new patch that has Kathey's considerations implemented. I have also
changed the way lastAssignedPort is initialized.
I was wondering about whether it would be acceptable to encapsulate the
following code into a BaseTestCase method.
static {
String port = BaseTestCase.getSystemProperty("derby.tests.basePort");
if (port == null) {
lastAssignedPort = DEFAULT_PORT;
} else {
lastAssignedPort = Integer.parseInt(port);
}
}
It is repeated three times throughout TestConfiguration and I thought that
maybe we could have a getBasePort() in BaseTestCase that simply retrieves that
property. Otherwise we can just leave it as is.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217-basePort.patch, DERBY-4217-basePort.patch,
> DERBY-4217-dtap.patch, DERBY-4217-dtap.patch, DERBY-4217-dtp.patch,
> DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
> DERBY-4217-dtp.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
> DERBY-4217-ij.stat, DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ErrorLog_suitesAll_bound.tgz, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
