[
https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tiago R. Espinha updated DERBY-4757:
------------------------------------
Attachment: DERBY-4757_p3.diff
I'm uploading what would be the final patch for this issue. Here's a quick
overview of what it does:
- Adds methods to NetAgent that allow for a switch between the current CCSID
manager being used.
- Defines the codepoint for UNICODEMGR as per the ACR.
- Defines a target level for the UnicodeMgr. This is the target that ideally we
want to achieve (1208) but might have to fall back to 0 in case the server does
not support it (old servers).
- Adds a method to NetConnection that returns true or false depending on
whether the server supports the UnicodeMgr at level 1208.
- Writes the UNICODEMGR codepoint and reads it back from the server for the
MGRLVLS negotiation.
This patch also enables the InternationalConnectTest to run on client/server
mode as opposed to before, where it ran only on embedded mode and expected an
exception in case it was running on client/server.
It needs to be mentioned that at this point, if the client falls back to level
0 on the UNICODEMGR (this happens if the server does not support UTF-8, i.e.
any Derby versions lower than 10.7) then we will not send the RDBNAM at the
ACCSEC. This will cause the server to throw a SYNTAXRM since it expected the
RDBNAM and the client will, by consequence, also throw a SYNTAXRM. This crash
is supposed to happen as the older servers just don't support UTF-8 characters.
What is left for improvement is the exception thrown by the client, which can
be a little more explicit and explain what is happening. After discussing this
issue with Kathey on IRC however, we agreed that we could go ahead as it is to
ensure this makes it to the 10.7 release and then at a later stage we can
improve the exception.
I'll be running regressions tonight. Please review my patch and if there are no
objections I'd like to go ahead and commit this soon.
> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
> Key: DERBY-4757
> URL: https://issues.apache.org/jira/browse/DERBY-4757
> Project: Derby
> Issue Type: Sub-task
> Components: Network Client
> Affects Versions: 10.7.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff,
> DERBY-4757_p2.diff, DERBY-4757_p3.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to
> implement UTF8 support in DRDA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
