[ 
https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tiago R. Espinha updated DERBY-4757:
------------------------------------

    Attachment: DERBY-4757_p3.diff

Thank you for your comments Bryan.

With the latest patch I've fixed both the regressions I was hitting. One of 
them had to do with the jdbcapi/AuthenticationTest.java where we expected the 
connection to fail whenever Greek characters were used. Obviously, we do now 
support Greek characters and as such the test should pass.

The second regression was with something I overlooked. I forgot to reset the 
CCSID manager back to EBCDIC for new sessions, which meant that if a client was 
to negotiate UTF-8, all the subsequent connections would be using UTF-8. This 
would fail as all connections must start as EBCDIC for the initial negotiation.

Logically, this two-line fix should be part of DERBY-4746 that deals with the 
server but seeing as these two issues go hand in hand, I think sneaking in this 
fix here should be fine. The server implementation in DERBY-4746 stands for 
itself, but when the client kicks in, we need this additional fix.

I'll be running regressions and if there are no failures and no one objects, 
I'd like to go ahead and check this in so that we can have it on time for a 
10.7 release.

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, 
> DERBY-4757_p2.diff, DERBY-4757_p3.diff, DERBY-4757_p3.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to 
> implement UTF8 support in DRDA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to